Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10008104: Regexp.rightContext was still not quite right. Fixed and (Closed)

Created:
8 years, 8 months ago by Erik Corry
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Regexp.rightContext was still not quite right. Fixed and added more tests. Committed: https://code.google.com/p/v8/source/detail?r=11312

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -8 lines) Patch
M src/macros.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/regexp.js View 1 4 chunks +9 lines, -7 lines 0 comments Download
M test/mjsunit/regexp-capture-3.js View 1 chunk +59 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
8 years, 8 months ago (2012-04-13 07:58:57 UTC) #1
Erik Corry
8 years, 8 months ago (2012-04-13 08:17:22 UTC) #2
Michael Starzinger
8 years, 8 months ago (2012-04-13 10:39:46 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698