gdata: Support mouting archive file in GData cache

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 
 /**
  * FileManager constructor.
  *
@@ skipping 2933 matching lines @@
       var position = 0;
       if (urls.length == 1) {
         // If just a single audio file is selected pass along every audio file
         // in the directory.
         var selectedUrl = urls[0];
         urls = this.getAllUrlsInCurrentDirectory_().filter(FileType.isAudio);
         position = urls.indexOf(selectedUrl);
       }
       chrome.mediaPlayerPrivate.play(urls, position);
     } else if (id == 'mount-archive') {
-      for (var index = 0; index < urls.length; ++index) {
-        // Url in MountCompleted event won't be escaped, so let's make sure
-        // we don't use escaped one in mountRequests_.
-        var unescapedUrl = unescape(urls[index]);
-        this.mountRequests_.push(unescapedUrl);
-        chrome.fileBrowserPrivate.addMount(unescapedUrl, 'file', {});
-      }
+      var self = this;
+      this.resolveSelectResults_(urls, function(urls) {

[Ben Chan, 2012/04/17 20:57:53]

Have you tested if this change also works with archives in non-gdata directory
(e.g. in Downloads)?

[hshi, 2012/04/17 21:21:45]

Yes this is tested with archives in non-gdata directory such as Downloads. It
works because resolveSelectResults_ checks for (this.isOnGData()) and will only
invoke private.getGDataFiles() for files in gdata; for non-gdata it   is a
passthru.

+        for (var index = 0; index < urls.length; ++index) {
+          // Url in MountCompleted event won't be escaped, so let's make sure
+          // we don't use escaped one in mountRequests_.
+          var unescapedUrl = unescape(urls[index]);
+          self.mountRequests_.push(unescapedUrl);
+          chrome.fileBrowserPrivate.addMount(unescapedUrl, 'file', {});
+        }
+      });
     } else if (id == 'format-device') {
       this.confirm.show(str('FORMATTING_WARNING'), function() {
         chrome.fileBrowserPrivate.formatDevice(urls[0]);
       });
     } else if (id == 'gallery') {
       this.openGallery_(urls);
     } else if (id == 'view-pdf' || id == 'view-in-browser' ||
         id == 'install-crx' || id == 'open-hosted') {
       chrome.fileBrowserPrivate.viewFiles(urls, 'default', function(success) {
         if (!success)
@@ skipping 1755 matching lines @@
 
     chrome.fileBrowserPrivate.setGDataPreferences(changeInfo);
 
     if (oldValue) {
       event.target.removeAttribute('checked');
     } else {
       event.target.setAttribute('checked', 'checked');
     }
   };
 })();