Exclude SyncSchedulerTest.TranisentPollFailure on ASAN

Exclude SyncSchedulerTest.TranisentPollFailure on ASAN


BUG=118370
TEST=sync_unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132118

[eroman, 2012-04-12 23:58:33]

lgtm

[commit-bot: I haz the power, 2012-04-13 00:00:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/10008098/1

[Timur Iskhodzhanov, 2012-04-13 08:35:17]

Wait a sec,
do you know that ASan does NOT read gtest_exclude files?

[tim (not reviewing), 2012-04-13 18:44:58]

On 2012/04/13 08:35:17, Timur Iskhodzhanov wrote:
> Wait a sec,
> do you know that ASan does NOT read gtest_exclude files?

Oh noes!  I did not know that :(  I noticed a few other -asan files in
valgrind/gtest_exclude, so I fell victim to groupthink.  e.g. {base_unittests,
browser_tests).gtest-asan.txt

Should we revert this, then, and look for another option for this test?  Is it
possible to make it read these files?

[Timur Iskhodzhanov, 2012-04-13 18:50:26]

On 2012/04/13 18:44:58, timsteele wrote:
> On 2012/04/13 08:35:17, Timur Iskhodzhanov wrote:
> > Wait a sec,
> > do you know that ASan does NOT read gtest_exclude files?
> 
> Oh noes!  I did not know that :(  I noticed a few other -asan files in
> valgrind/gtest_exclude, so I fell victim to groupthink.  e.g. {base_unittests,
> browser_tests).gtest-asan.txt
Hm, they shouldn't exist too.
glider@, mind taking a look?

> Should we revert this, then,
yes

> Is it possible to make it read these files?
no, by design [talk to glider@ if you need details]

>and look for another option for this test?
My opinion here:
http://code.google.com/p/chromium/issues/detail?id=118370#c7

btw, it looks like you've sent the CL since you were a sheriff?
Chatting with glider@ we thought that sheriffs shouldn't usually know about
tools/valgrind/gtest_exclude files
and those brave souls who do know - should also know that tools/valgrind doesn't
apply to ASan.
Since you're amongst the brave ones - can you please suggest a good way to
remind other brave souls about that?
e.g. tools/valgrind/gtest_exclude/README.txt or .../NO_ASAN_HERE.txt or
chromium-dev FYI mail or ...?

Thanks!

[tim (not reviewing), 2012-04-13 18:57:52]

On 2012/04/13 18:50:26, Timur Iskhodzhanov wrote:
> On 2012/04/13 18:44:58, timsteele wrote:
> > On 2012/04/13 08:35:17, Timur Iskhodzhanov wrote:
> > > Wait a sec,
> > > do you know that ASan does NOT read gtest_exclude files?
> > 
> > Oh noes!  I did not know that :(  I noticed a few other -asan files in
> > valgrind/gtest_exclude, so I fell victim to groupthink.  e.g.
{base_unittests,
> > browser_tests).gtest-asan.txt
> Hm, they shouldn't exist too.
> glider@, mind taking a look?
> 
> > Should we revert this, then,
> yes
> 
> > Is it possible to make it read these files?
> no, by design [talk to glider@ if you need details]
> 
> >and look for another option for this test?
> My opinion here:
> http://code.google.com/p/chromium/issues/detail?id=118370#c7
> 
> btw, it looks like you've sent the CL since you were a sheriff?
> Chatting with glider@ we thought that sheriffs shouldn't usually know about
> tools/valgrind/gtest_exclude files
> and those brave souls who do know - should also know that tools/valgrind
doesn't
> apply to ASan.
> Since you're amongst the brave ones - can you please suggest a good way to
> remind other brave souls about that?
> e.g. tools/valgrind/gtest_exclude/README.txt or .../NO_ASAN_HERE.txt or
> chromium-dev FYI mail or ...?
> 
> Thanks!

Well, I was a hybrid case here :)  I know this test particularly well since I
wrote it (and I know it's disabled under tsan).  I also happened to be sheriff
when I noticed it flake on asan.

Really sorry for extending the broken pattern :(

I'll take a look at the tests in the existing gtest_exclude-asan files and your
comments above and try to summarize + propose workaround with a mail to
chromium-dev.