Issue 10008082: Fix native ARM build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10008082: Fix native ARM build (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow

Modified:
8 years, 8 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix native ARM build BUG=v8:1744, v8:539 Committed: https://code.google.com/p/v8/source/detail?r=11300

Patch Set 2 : fix 80-col #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
M	Makefile	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Please take a look. Tested for simulator builds (on x64) and native builds on ARM. ...

8 years, 8 months ago (2012-04-13 07:28:18 UTC) #1

danno

LGTM with comments https://chromiumcodereview.appspot.com/10008082/diff/1001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10008082/diff/1001/build/common.gypi#newcode286 build/common.gypi:286: 'm32flag': '<!((echo | $(echo ${CXX:-$(which g++)}) ...

8 years, 8 months ago (2012-04-13 07:44:30 UTC) #2

Thanks, nit fixed, landing.

Expand Messages | Collapse Messages

Issue 10008082: Fix native ARM build (Closed)

Description

Patch Set 1 : #

Patch Set 2 : fix 80-col #

Messages