runtime/bin/http_impl.dart - Issue 10008075: Close socket, and not non-existing outputStream. Fixes crash in HttpServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_impl.dart

Issue 10008075: Close socket, and not non-existing outputStream. Fixes crash in HttpServer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Don't include old commit. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/http_impl.dart

diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart

index 064975269f31e01201a537de3b8eada7e6d6fba3..1675d345be80658e4c02545d195ef3ed88e981f1 100644

--- a/runtime/bin/http_impl.dart

+++ b/runtime/bin/http_impl.dart

@@ -632,7 +632,7 @@ class _HttpConnection extends _HttpConnectionBase {

// If the connection is closing then close the output stream to

// fully close the socket.

if (_closing) {

- outputStream.close();

+ _socket.close();

}

_response = null;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »