runtime/vm/parser.cc - Issue 10008017: Do not require upper bounds to be resolved and finalized before comparing them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 10008017: Do not require upper bounds to be resolved and finalized before comparing them (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 6231)

+++ runtime/vm/parser.cc (working copy)

@@ -2910,12 +2910,9 @@

// can be omitted), verify that it matches the list of type parameters of

// the interface in number and names.

if (factory_class.NumTypeParameters() > 0) {

- const TypeArguments& interface_type_parameters =

- TypeArguments::Handle(interface.type_parameters());

- const TypeArguments& factory_type_parameters =

- TypeArguments::Handle(factory_class.type_parameters());

- if (!TypeArguments::AreIdenticalTypeParameters(interface_type_parameters,

- factory_type_parameters)) {

+ if (!AbstractTypeArguments::AreIdentical(

+ AbstractTypeArguments::Handle(interface.type_parameters()),

+ AbstractTypeArguments::Handle(factory_class.type_parameters()))) {

const String& interface_name = String::Handle(interface.Name());

ErrorMsg(factory_name.ident_pos,

"mismatch in number or names of type parameters between "

« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/language.status » ('j') | no next file with comments »