content/browser/tab_contents/test_web_contents.cc - Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/test_web_contents.cc

Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on feedback and new test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/test_web_contents.cc

diff --git a/content/browser/tab_contents/test_web_contents.cc b/content/browser/tab_contents/test_web_contents.cc

index da27f49e8b4128adee0d083cf805cfc4893513f7..e8408df5ab58432584ca3f71a627e926c9fe1b2b 100644

--- a/content/browser/tab_contents/test_web_contents.cc

+++ b/content/browser/tab_contents/test_web_contents.cc

@@ -134,7 +134,7 @@ void TestWebContents::CommitPendingNavigation() {

// Simulate the SwapOut_ACK that fires if you commit a cross-site navigation

// without making any network requests.

if (old_rvh != rvh)

- static_cast<RenderViewHostImpl*>(old_rvh)->OnSwapOutACK();

+ static_cast<RenderViewHostImpl*>(old_rvh)->OnSwapOutACK(false);

}

int TestWebContents::GetNumberOfFocusCalls() {