content/browser/renderer_host/render_widget_host_impl.h - Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 10008015: Fixing a problem, where a hung renderer process is not killed when navigating away (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on feedback and new test Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/renderer_host/render_widget_helper.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index ca16dbc5e4cde46ccce7b5342d846f2f953eb2dd..adc6674ee3b1cf19f97522ba326969b932702926 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -414,6 +414,11 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,

void SetShouldAutoResize(bool enable);

protected:

+ // Expose increment/decrement of the in-flight event count, so

+ // RenderViewHostImpl can account for in-flight beforeunload/unload events.

+ int increment_in_flight_event_count() { return ++in_flight_event_count_; }

+ int decrement_in_flight_event_count() { return --in_flight_event_count_; }

// The View associated with the RenderViewHost. The lifetime of this object

// is associated with the lifetime of the Render process. If the Renderer

// crashes, its View is destroyed and this pointer becomes NULL, even though