Fixing a problem, where a hung renderer process is not killed when navigating away

content/browser/renderer_host/render_widget_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 #pragma once
 
 #include <deque>
 #include <string>
@@ skipping 396 matching lines @@
   bool IsMouseLocked() const;
 
   // RenderViewHost overrides this method to report when in fullscreen mode.
   virtual bool IsFullscreen() const;
 
   // Indicates if the render widget host should track the render widget's size
   // as opposed to visa versa.
   void SetShouldAutoResize(bool enable);
 
  protected:
+  // Expose increment/decrement of the in-flight event count, so
+  // RenderViewHostImpl can account for in-flight beforeunload/unload events.
+  int IncrementInFlightEventCount() { return ++in_flight_event_count_; }
+  int DecrementInFlightEventCount() { return --in_flight_event_count_; }

[Charlie Reis, 2012/04/06 22:34:14]

These are small enough to be inlined, so we should use unix_hacker_style().

http://www.chromium.org/developers/coding-style
"Google style strongly encourages (but does not mandate) unix_hacker style on
member functions that do so little work they're effectively free, such as
simple, non-virtual getters and setters. This is also the team position. Some
code uses CamelCase for everything; avoid writing patches just to convert these
functions to unix_hacker style, but try to use it in new code you write unless
there are encapsulation reasons why CamelCase would be much more appropriate."

[nasko, 2012/04/10 00:16:37]

Done.

+
   // The View associated with the RenderViewHost. The lifetime of this object
   // is associated with the lifetime of the Render process. If the Renderer
   // crashes, its View is destroyed and this pointer becomes NULL, even though
   // render_view_host_ lives on to load another URL (creating a new View while
   // doing so).
   RenderWidgetHostViewPort* view_;
 
   // true if a renderer has once been valid. We use this flag to display a sad
   // tab only when we lose our renderer and not if a paint occurs during
   // initialization.
@@ skipping 273 matching lines @@
   base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
 
   scoped_ptr<TapSuppressionController> tap_suppression_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_