First indexeddb test

First indexeddb test


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6252

[vsm, 2012-04-05 20:11:28]

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
File client/tests/client/dom/IndexedDB1Test.dart (right):

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:7: final String VERSION = '1';
Consistent all caps for constants?

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:20: createObjectStore(e) {
Drop argument if unused / unnecessary.

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:28: var request =
db.setVersion(VERSION);
Do you mean to use the uppercase VERSION in this line and the lowercase version
in the line above?

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:29: request.onsuccess = (e) {
createObjectStore(e); andThen(); };
Perhaps just call step1 directly instead of the andThen continuation.  Note, you
do call step2 directly from step1.

https://chromiumcodereview.appspot.com/10008012/diff/3/tools/testing/dart/bro...
File tools/testing/dart/browser_test.dart (right):

https://chromiumcodereview.appspot.com/10008012/diff/3/tools/testing/dart/bro...
tools/testing/dart/browser_test.dart:26: onerror = function(message, url,
lineNumber) {
Can you add a console.error here with the message instead of silently swallowing
(assuming the test framework isn't printing it before invoking onerror)?

[sra1, 2012-04-05 21:23:08]

PTAL

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
File client/tests/client/dom/IndexedDB1Test.dart (right):

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:7: final String VERSION = '1';
On 2012/04/05 20:11:28, vsm wrote:
> Consistent all caps for constants?

Done.

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:20: createObjectStore(e) {
On 2012/04/05 20:11:28, vsm wrote:
> Drop argument if unused / unnecessary.

Done.

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:28: var request =
db.setVersion(VERSION);
On 2012/04/05 20:11:28, vsm wrote:
> Do you mean to use the uppercase VERSION in this line and the lowercase
version
> in the line above?

Done.

https://chromiumcodereview.appspot.com/10008012/diff/3/client/tests/client/do...
client/tests/client/dom/IndexedDB1Test.dart:29: request.onsuccess = (e) {
createObjectStore(e); andThen(); };
On 2012/04/05 20:11:28, vsm wrote:
> Perhaps just call step1 directly instead of the andThen continuation.  Note,
you
> do call step2 directly from step1.

Done.

https://chromiumcodereview.appspot.com/10008012/diff/3/tools/testing/dart/bro...
File tools/testing/dart/browser_test.dart (right):

https://chromiumcodereview.appspot.com/10008012/diff/3/tools/testing/dart/bro...
tools/testing/dart/browser_test.dart:26: onerror = function(message, url,
lineNumber) {
On 2012/04/05 20:11:28, vsm wrote:
> Can you add a console.error here with the message instead of silently
swallowing
> (assuming the test framework isn't printing it before invoking onerror)?

The message seems to always be 'Script error' with no url or line.

[vsm, 2012-04-05 22:15:45]

lgtm