src/hydrogen.cc - Issue 10008007: Ensure HAllocateObject always allocates in new-space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 10008007: Ensure HAllocateObject always allocates in new-space. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Improved test case to use small objects. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 2255ab6f971f6d679d92253f2a567d5fb01aa6f4..7be83bed13312528d799b5964f28402e010f1690 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -6028,7 +6028,8 @@ void HGraphBuilder::VisitCall(Call* expr) {

// Checks whether allocation using the given constructor can be inlined.

static bool IsAllocationInlineable(Handle<JSFunction> constructor) {

return constructor->has_initial_map() &&

- constructor->initial_map()->instance_type() == JS_OBJECT_TYPE;

+ constructor->initial_map()->instance_type() == JS_OBJECT_TYPE &&

+ constructor->initial_map()->instance_size() < HAllocateObject::kMaxSize;

}

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »