Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 10007047: Merge 112740 - IndexedDB: Race condition causes version change transaction to commit after onblocked (Closed)

Created:
8 years, 8 months ago by jsbell
Modified:
8 years, 8 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112740 - IndexedDB: Race condition causes version change transaction to commit after onblocked https://bugs.webkit.org/show_bug.cgi?id=82678 Source/WebCore: For a version change event, the blocked and success events could both be queued before either is dispatched. The transaction would erroneously be allowed to commit after the blocked event was dispatched; it should not be, as the request was not finished. Reviewed by Tony Chang. Test: storage/indexeddb/dont-commit-on-blocked.html * Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent): LayoutTests: Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will run it as a Chromium browser test for now. Reviewed by Tony Chang. * platform/chromium/test_expectations.txt: * storage/indexeddb/dont-commit-on-blocked.html: Added. * storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added. (request.onsuccess): (onSetVersionBlocked): (onSetVersionSuccess): (onTransactionComplete): TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --2 lines) Patch
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/storage/indexeddb/dont-commit-on-blocked.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/storage/indexeddb/resources/dont-commit-on-blocked-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
8 years, 8 months ago (2012-04-06 21:48:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698