Make crash reporting link creation easier to read

Make crash reporting link creation easier to read

BUG=none
TEST=crash reporting still works (need to build Chrome, not Chromium) and dbeam%40%20doesn't%20go%20crazy%20trying%20to%20read%20it

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134640

[Dan Beam, 2012-04-06 20:40:08]

https://chromiumcodereview.appspot.com/10007040/diff/1/chrome/browser/resourc...
File chrome/browser/resources/crashes.js (right):

https://chromiumcodereview.appspot.com/10007040/diff/1/chrome/browser/resourc...
chrome/browser/resources/crashes.js:51: comment: 'Chrome Version: ' + version +
'\n' +
probably easier to read if you:

  ['line',
   'line',
   'line'].join('\n')

[Dan Beam, 2012-04-19 02:08:03]

ping

[Tyler Breisacher (Chromium), 2012-04-30 21:38:23]

Another one that I kinda forgot about...

https://chromiumcodereview.appspot.com/10007040/diff/1/chrome/browser/resourc...
File chrome/browser/resources/crashes.js (right):

https://chromiumcodereview.appspot.com/10007040/diff/1/chrome/browser/resourc...
chrome/browser/resources/crashes.js:51: comment: 'Chrome Version: ' + version +
'\n' +
On 2012/04/06 20:40:08, Dan Beam wrote:
> probably easier to read if you:
> 
>   ['line',
>    'line',
>    'line'].join('\n')

Done.

[Dan Beam, 2012-04-30 22:53:55]

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
File chrome/browser/resources/crashes.js (right):

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
chrome/browser/resources/crashes.js:68: 'report_id:' + crash.id].join('\n'),
might be less awkward if you moved this into a separate var as each entry in the
array should probably be lined up or something, i.e.

  var a = ['a',
           'b',
           'c'].join('\n');

and you could additionally do a.join('\n') later so it's harder to miss while
reading the code...

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
chrome/browser/resources/crashes.js:72: href += encodeURIComponent(param) + '='
+
use appendParam() from util.js instead

[Tyler Breisacher (Chromium), 2012-04-30 23:18:11]

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
File chrome/browser/resources/crashes.js (right):

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
chrome/browser/resources/crashes.js:68: 'report_id:' + crash.id].join('\n'),
On 2012/04/30 22:53:55, Dan Beam wrote:
> might be less awkward if you moved this into a separate var as each entry in
the
> array should probably be lined up or something, i.e.
> 
>   var a = ['a',
>            'b',
>            'c'].join('\n');
> 
> and you could additionally do a.join('\n') later so it's harder to miss while
> reading the code...

Done.

https://chromiumcodereview.appspot.com/10007040/diff/4002/chrome/browser/reso...
chrome/browser/resources/crashes.js:72: href += encodeURIComponent(param) + '='
+
On 2012/04/30 22:53:55, Dan Beam wrote:
> use appendParam() from util.js instead

Done.

[Dan Beam, 2012-04-30 23:42:04]

lgtm w/nit

https://chromiumcodereview.appspot.com/10007040/diff/9002/chrome/browser/reso...
File chrome/browser/resources/crashes.js (right):

https://chromiumcodereview.appspot.com/10007040/diff/9002/chrome/browser/reso...
chrome/browser/resources/crashes.js:49: var commentLines = [
2 \s in JS