Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: src/profile-generator-inl.h

Issue 10007009: External references should not affect dominance relation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/profile-generator.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // To avoid confusing people, let's put all these entries into 88 // To avoid confusing people, let's put all these entries into
89 // one bucket. 89 // one bucket.
90 case OTHER: 90 case OTHER:
91 case EXTERNAL: 91 case EXTERNAL:
92 return program_entry_; 92 return program_entry_;
93 default: return NULL; 93 default: return NULL;
94 } 94 }
95 } 95 }
96 96
97 97
98 HeapEntry* HeapGraphEdge::from() {
99 return reinterpret_cast<HeapEntry*>(this - child_index_) - 1;
100 }
101
102
98 SnapshotObjectId HeapObjectsMap::GetNthGcSubrootId(int delta) { 103 SnapshotObjectId HeapObjectsMap::GetNthGcSubrootId(int delta) {
99 return kGcRootsFirstSubrootId + delta * kObjectIdStep; 104 return kGcRootsFirstSubrootId + delta * kObjectIdStep;
100 } 105 }
101 106
102 107
103 HeapObject* V8HeapExplorer::GetNthGcSubrootObject(int delta) { 108 HeapObject* V8HeapExplorer::GetNthGcSubrootObject(int delta) {
104 return reinterpret_cast<HeapObject*>( 109 return reinterpret_cast<HeapObject*>(
105 reinterpret_cast<char*>(kFirstGcSubrootObject) + 110 reinterpret_cast<char*>(kFirstGcSubrootObject) +
106 delta * HeapObjectsMap::kObjectIdStep); 111 delta * HeapObjectsMap::kObjectIdStep);
107 } 112 }
108 113
109 114
110 int V8HeapExplorer::GetGcSubrootOrder(HeapObject* subroot) { 115 int V8HeapExplorer::GetGcSubrootOrder(HeapObject* subroot) {
111 return static_cast<int>( 116 return static_cast<int>(
112 (reinterpret_cast<char*>(subroot) - 117 (reinterpret_cast<char*>(subroot) -
113 reinterpret_cast<char*>(kFirstGcSubrootObject)) / 118 reinterpret_cast<char*>(kFirstGcSubrootObject)) /
114 HeapObjectsMap::kObjectIdStep); 119 HeapObjectsMap::kObjectIdStep);
115 } 120 }
116 121
117 } } // namespace v8::internal 122 } } // namespace v8::internal
118 123
119 #endif // V8_PROFILE_GENERATOR_INL_H_ 124 #endif // V8_PROFILE_GENERATOR_INL_H_
OLDNEW
« no previous file with comments | « src/profile-generator.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698