Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10006052: Further automation. Occasionaly we get a new svn server certificate, and we get (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 6293)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -73,7 +73,7 @@
"""First, some utility methods."""
-def run_cmd(cmd_list, outfile=None, append=False):
+def run_cmd(cmd_list, outfile=None, append=False, std_in=''):
"""Run the specified command and print out any output to stdout.
Args:
@@ -94,9 +94,9 @@
# explicitly go to the end of the file.
# http://mail.python.org/pipermail/python-list/2009-October/1221859.html
out.seek(0, os.SEEK_END)
- p = subprocess.Popen(cmd_list, stdout = out, stderr = subprocess.PIPE,
- shell=HAS_SHELL)
- output, not_used = p.communicate();
+ p = subprocess.Popen(cmd_list, stdout = out, stderr=subprocess.PIPE,
+ stdin=subprocess.PIPE, shell=HAS_SHELL)
+ output, not_used = p.communicate(std_in);
if output:
print output
return output
@@ -164,7 +164,9 @@
def has_new_code():
"""Tests if there are any newer versions of files on the server."""
os.chdir(DART_INSTALL_LOCATION)
- results = run_cmd(['svn', 'st', '-u'])
+ # Pass 'p' in if we have a new certificate for the svn server, we want to
+ # (p)ermanently accept it.
+ results = run_cmd(['svn', 'st', '-u'], std_in='p')
for line in results:
if '*' in line:
return True
@@ -242,10 +244,9 @@
'dromaeo.html'))
shutil.copyfile('data.html', os.path.join('appengine', 'static',
'data.html'))
- p = subprocess.Popen([os.path.join('..', '..', '..', 'third_party',
+ run_cmd([os.path.join('..', '..', '..', 'third_party',
'appengine-python', 'appcfg.py'), '--oauth2', 'update',
- 'appengine/'], shell=HAS_SHELL, stdin=subprocess.PIPE)
- p.communicate()
+ 'appengine/'])
class TestRunner(object):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698