Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5194)

Unified Diff: chrome/test/base/testing_profile.cc

Issue 10006037: Moved WebDataService to ProfileKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reverted one unneeded change Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index 7d26924df929de1a9102248ef2297d5aa1eaa7cb..93a38cefac511cf53b684140b3119f9a8d865aef 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -234,7 +234,6 @@ TestingProfile::~TestingProfile() {
DestroyHistoryService();
// FaviconService depends on HistoryServce so destroying it later.
DestroyFaviconService();
- DestroyWebDataService();
if (pref_proxy_config_tracker_.get())
pref_proxy_config_tracker_->DetachFromPrefService();
@@ -327,21 +326,6 @@ void TestingProfile::CreateProtocolHandlerRegistry() {
new ProtocolHandlerRegistry::Delegate());
}
-void TestingProfile::CreateWebDataService(bool delete_file) {
- if (web_data_service_.get())
- web_data_service_->Shutdown();
-
- if (delete_file) {
- FilePath path = GetPath();
- path = path.Append(chrome::kWebDataFilename);
- file_util::Delete(path, false);
- }
-
- web_data_service_ = new WebDataService;
- if (web_data_service_.get())
- web_data_service_->Init(GetPath());
-}
-
void TestingProfile::BlockUntilBookmarkModelLoaded() {
DCHECK(bookmark_bar_model_.get());
if (bookmark_bar_model_->IsLoaded())
@@ -487,14 +471,6 @@ history::ShortcutsBackend* TestingProfile::GetShortcutsBackend() {
return NULL;
}
-WebDataService* TestingProfile::GetWebDataService(ServiceAccessType access) {
- return web_data_service_.get();
-}
-
-WebDataService* TestingProfile::GetWebDataServiceWithoutCreating() {
- return web_data_service_.get();
-}
-
void TestingProfile::SetPrefService(PrefService* prefs) {
#if defined(ENABLE_PROTECTOR_SERVICE)
// ProtectorService binds itself very closely to the PrefService at the moment
@@ -708,13 +684,6 @@ quota::SpecialStoragePolicy* TestingProfile::GetSpecialStoragePolicy() {
return GetExtensionSpecialStoragePolicy();
}
-void TestingProfile::DestroyWebDataService() {
- if (!web_data_service_.get())
- return;
-
- web_data_service_->Shutdown();
-}
-
bool TestingProfile::WasCreatedByVersionOrLater(const std::string& version) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698