Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/test/base/chrome_render_view_host_test_harness.cc

Issue 10006037: Moved WebDataService to ProfileKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reverted one unneeded change Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/chrome_render_view_host_test_harness.cc
diff --git a/chrome/test/base/chrome_render_view_host_test_harness.cc b/chrome/test/base/chrome_render_view_host_test_harness.cc
index 950ade3902af56d5fdbf50cb345dcf34f6835a89..2b074b25b23e7197d742ccf7c0eed981f1c539dc 100644
--- a/chrome/test/base/chrome_render_view_host_test_harness.cc
+++ b/chrome/test/base/chrome_render_view_host_test_harness.cc
@@ -4,6 +4,7 @@
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chrome/browser/webdata/web_data_service_factory.h"
#include "chrome/test/base/testing_profile.h"
#if defined(USE_ASH)
@@ -40,6 +41,11 @@ RenderViewHostTester* ChromeRenderViewHostTestHarness::rvh_tester() {
void ChromeRenderViewHostTestHarness::SetUp() {
if (!browser_context_.get())
browser_context_.reset(new TestingProfile());
+ // WebDataService is not used in ChromeRenderViewHostTest, but requires DB
+ // thread if instantiated.
+ WebDataServiceFactory::GetInstance()->SetTestingFactory(
sky 2012/04/17 20:59:20 Does this prevent anyone from creating a ChromeRen
GeorgeY 2012/04/17 21:05:18 Not a single test does apparently. I one would do
+ Profile::FromBrowserContext(browser_context_.get()), NULL);
+
RenderViewHostTestHarness::SetUp();
}

Powered by Google App Engine
This is Rietveld 408576698