chrome/browser/ui/views/first_run_bubble_unittest.cc - Issue 10006037: Moved WebDataService to ProfileKeyedService

Unified Diff: chrome/browser/ui/views/first_run_bubble_unittest.cc

Issue 10006037: Moved WebDataService to ProfileKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reverted one unneeded change Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/first_run_bubble_unittest.cc

diff --git a/chrome/browser/ui/views/first_run_bubble_unittest.cc b/chrome/browser/ui/views/first_run_bubble_unittest.cc

index e479bd55caae62b89d19c636cbf3e165a1c794dc..1580b585ed08b8f1a58bec9ca267d54a1566afef 100644

--- a/chrome/browser/ui/views/first_run_bubble_unittest.cc

+++ b/chrome/browser/ui/views/first_run_bubble_unittest.cc

@@ -6,6 +6,7 @@

#include "chrome/browser/search_engines/template_url_service.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/ui/views/first_run_bubble.h"

+#include "chrome/browser/webdata/web_data_service_factory.h"

#include "chrome/test/base/testing_profile.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/views/test/views_test_base.h"

@@ -36,6 +37,9 @@ FirstRunBubbleTest::~FirstRunBubbleTest() {}

void FirstRunBubbleTest::SetUp() {

ViewsTestBase::SetUp();

profile_.CreateTemplateURLService();

+ // WebDataService is not used in the test, but requires DB thread if

+ // instantiated.

+ WebDataServiceFactory::GetInstance()->SetTestingFactory(&profile_, NULL);

Ilya Sherman 2012/04/17 21:32:15 Given that all of these individual tests need to a

GeorgeY 2012/04/18 18:14:46 Done.

Ilya Sherman 2012/04/18 18:25:05 I actually meant the full snippet, including "WebD

GeorgeY 2012/04/19 00:58:40 Done.

TemplateURLService* turl_model =

TemplateURLServiceFactory::GetForProfile(&profile_);

turl_model->Load();