Add element to qualifier name for code completion

Add element to qualifier name for code completion

http://code.google.com/p/dart/issues/detail?id=2422

Committed: https://code.google.com/p/dart/source/detail?r=6272

[zundel, 2012-04-06 12:48:15]

@Steve, let me know what you want me to do with the mods to CompletionEngine. I
could just revert them and let you handle them more gracefully if you prefer.

https://chromiumcodereview.appspot.com/10006030/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

https://chromiumcodereview.appspot.com/10006030/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1134: if
(x.getName() != null) {
fixed formatting glitch locally.

https://chromiumcodereview.appspot.com/10006030/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
(right):

https://chromiumcodereview.appspot.com/10006030/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java:690:
if (type != null) {
This is my hack to see if the changes I made really worked.  I'm sure something
better can be done.

https://chromiumcodereview.appspot.com/10006030/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java:788:
DartNode qualifier = completionNode.getQualifier();
This fixes the code completion in another case.  I'm fairly confident this is
the code we need because I got a ClassCastException at line 779

https://chromiumcodereview.appspot.com/10006030/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java:803:
}
There is also the case foo.^ where foo is a library. It should be set with a
LibraryElement, from which we could create completion proposals from the scope
of that library element, but we don't seem to at the moment.

[messick, 2012-04-06 13:59:21]

LGTM

Please commit the CompletionEngine changes. I'll deal with it later today. I
suspect there is more to be done, as you mentioned. :)

[scheglov, 2012-04-06 14:23:15]

LGTM