Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: net/url_request/url_request.cc

Issue 10006009: Track URLRequestContext references in a set. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add comments and track the number of leaked requests. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_context.h » ('j') | net/url_request/url_request_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 4c2e2c35385be5fd4baa4fe832b27a35bc6c1822..408e81235aa76b81942e30a9b49b715120ad3c2b 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -12,6 +12,7 @@
#include "base/memory/singleton.h"
#include "base/message_loop.h"
#include "base/metrics/stats_counters.h"
+#include "base/stl_util.h"
#include "base/synchronization/lock.h"
#include "net/base/auth.h"
#include "net/base/host_port_pair.h"
@@ -49,6 +50,7 @@ void StripPostSpecificHeaders(HttpRequestHeaders* headers) {
headers->RemoveHeader(HttpRequestHeaders::kOrigin);
}
wtc 2012/04/05 21:37:16 Nit: undo this blank line.
+
// TODO(battre): Delete this, see http://crbug.com/89321:
// This counter keeps track of the identifiers used for URL requests so far.
// 0 is reserved to represent an invalid ID.
@@ -714,6 +716,19 @@ const URLRequestContext* URLRequest::context() const {
}
void URLRequest::set_context(const URLRequestContext* context) {
+ // Update the URLRequest lists in the URLRequestContext.
+ if (context_) {
+ std::set<const URLRequest*>* url_requests = context_->url_requests();
+ CHECK(ContainsKey(*url_requests, this));
+ url_requests->erase(this);
+ }
+
+ if (context) {
+ std::set<const URLRequest*>* url_requests = context->url_requests();
+ CHECK(!ContainsKey(*url_requests, this));
+ url_requests->insert(this);
+ }
+
scoped_refptr<const URLRequestContext> prev_context = context_;
context_ = context;
« no previous file with comments | « no previous file | net/url_request/url_request_context.h » ('j') | net/url_request/url_request_context.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698