Issue 10006004: Add regression test case for issue 2025.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10006004: Add regression test case for issue 2025. (Closed)

Created:
8 years, 8 months ago by danno

Modified:
8 years, 8 months ago

Reviewers:
ulan, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add regression test case for issue 2025. R=ulan@chromium.org BUG=v8:2056 TEST=test/mjsunit/regress/regress-2056.js Committed: https://code.google.com/p/v8/source/detail?r=11231

Patch Set 2 : Remove unused parameter #

Patch Set 3 : Remove trailing whitepace #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -0 lines)			Patch
	A	test/mjsunit/regress/regress-2056.js	View	1 2	1 chunk	+68 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm http://codereview.chromium.org/10006004/diff/1/test/mjsunit/regress/regress-2056.js File test/mjsunit/regress/regress-2056.js (right): http://codereview.chromium.org/10006004/diff/1/test/mjsunit/regress/regress-2056.js#newcode44 test/mjsunit/regress/regress-2056.js:44: function do_min(c, a, b) { The 'c' argument ...

8 years, 8 months ago (2012-04-05 08:00:31 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-05 08:01:38 UTC) #3

Drive-by nit.

https://chromiumcodereview.appspot.com/10006004/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-2056.js (right):

https://chromiumcodereview.appspot.com/10006004/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-2056.js:69: 
Many trailing newlines.