test/regression/121.stmt - Issue 1000513002: Tweak formatting rules. Fix #211.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/regression/121.stmt

Issue 1000513002: Tweak formatting rules. Fix #211. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master

Patch Set: Update changelog. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 >>> (indent 6)	1 >>> (indent 6)

2 if (!firstArgument.isString) {	2 if (!firstArgument.isString) {

3 DartType type = defaultValue.getType(compiler.coreTypes);	3 DartType type = defaultValue.getType(compiler.coreTypes);

4 compiler.reportFatalError(	4 compiler.reportFatalError(

5 send.arguments.head,	5 send.arguments.head,

6 MessageKind.NOT_ASSIGNABLE,	6 MessageKind.NOT_ASSIGNABLE,

7 {	7 {

8 'fromType': type,	8 'fromType': type,

9 'toType': compiler.stringClass.rawType	9 'toType': compiler.stringClass.rawType

10 });	10 });

11 return null;	11 return null;

12 }	12 }

13 <<<	13 <<<

14 if (!firstArgument.isString) {	14 if (!firstArgument.isString) {

15 DartType type = defaultValue.getType(compiler.coreTypes);	15 DartType type = defaultValue.getType(compiler.coreTypes);

16 compiler.reportFatalError(send.arguments.head,	16 compiler.reportFatalError(send.arguments.head,

17 MessageKind.NOT_ASSIGNABLE,	17 MessageKind.NOT_ASSIGNABLE, {

18 {'fromType': type, 'toType': compiler.stringClass.rawType});	18 'fromType': type,

	19 'toType': compiler.stringClass.rawType

	20 });

19 return null;	21 return null;

20 }	22 }

OLD	NEW

« no previous file with comments | « lib/src/source_visitor.dart ('k') | test/regression/211.unit » ('j') | no next file with comments »