Issue 10005049: DomStorage house cleaning

Issue 10005049: DomStorage house cleaning (Closed)

Created:
8 years, 8 months ago by michaeln

Modified:
8 years, 8 months ago

Reviewers:
ericu

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

DomStorage house cleaning in preparation of deleting the now obsolete in_process_webkit support for this component. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132120

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -54 lines)			Patch
M	content/browser/dom_storage/dom_storage_message_filter_new.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/interstitial_page_impl.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/dom_storage_common.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/common/dom_storage_messages.h	View	1 2 3 4 5 6 7 8 9	3 chunks	+16 lines, -17 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+7 lines, -6 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/renderer_webstoragearea_impl.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -4 lines	0 comments	Download
M	content/renderer/renderer_webstoragenamespace_impl.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/renderer/renderer_webstoragenamespace_impl.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+5 lines, -8 lines	0 comments	Download
M	content/test/render_view_fake_resources_test.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/test/render_view_test.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/dom_storage/dom_storage_types.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_dom_storage_system.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

michaeln

Hi Eric, Can you take a look at this one? It's some house cleaning in ...

8 years, 8 months ago (2012-04-10 22:41:37 UTC) #1

michaeln

I'm working on similar house cleaning over on the webkit side too, that part's not ...

8 years, 8 months ago (2012-04-10 22:43:49 UTC) #2

ericu

LTGM https://chromiumcodereview.appspot.com/10005049/diff/15003/content/renderer/renderer_webstoragenamespace_impl.cc File content/renderer/renderer_webstoragenamespace_impl.cc (right): https://chromiumcodereview.appspot.com/10005049/diff/15003/content/renderer/renderer_webstoragenamespace_impl.cc#newcode21 content/renderer/renderer_webstoragenamespace_impl.cc:21: DCHECK_NE(dom_storage::kLocalStorageNamespaceId, namespace_id); Should this be kInvalidSessionStorageNamespaceId?

8 years, 8 months ago (2012-04-10 23:53:03 UTC) #3

michaeln

8 years, 8 months ago (2012-04-11 00:31:53 UTC) #4

https://chromiumcodereview.appspot.com/10005049/diff/15003/content/renderer/r...
File content/renderer/renderer_webstoragenamespace_impl.cc (right):

https://chromiumcodereview.appspot.com/10005049/diff/15003/content/renderer/r...
content/renderer/renderer_webstoragenamespace_impl.cc:21:
DCHECK_NE(dom_storage::kLocalStorageNamespaceId, namespace_id);
On 2012/04/10 23:53:03, ericu wrote:
> Should this be kInvalidSessionStorageNamespaceId?

Done.

Expand Messages | Collapse Messages