Issue 10005043: make importing matplotlib optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10005043: make importing matplotlib optional (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make importing Matplotlib optional. Committed: https://code.google.com/p/dart/source/detail?r=6290

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	tools/testing/browser_README.txt	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	tools/testing/perf_testing/run_perf_tests.py	View	1	3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://chromiumcodereview.appspot.com/10005043/diff/3001/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (right): https://chromiumcodereview.appspot.com/10005043/diff/3001/tools/testing/perf_testing/run_perf_tests.py#newcode382 tools/testing/perf_testing/run_perf_tests.py:382: # Only run Matplotlib if the Please fix ...

8 years, 8 months ago (2012-04-06 18:07:46 UTC) #2

Emily Fortuna

8 years, 8 months ago (2012-04-06 18:13:18 UTC) #3

https://chromiumcodereview.appspot.com/10005043/diff/3001/tools/testing/perf_...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/10005043/diff/3001/tools/testing/perf_...
tools/testing/perf_testing/run_perf_tests.py:382: # Only run Matplotlib if the
On 2012/04/06 18:07:46, vsm wrote:
> Please fix dangling comment.

Done.

Expand Messages | Collapse Messages

Issue 10005043: make importing matplotlib optional (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages