chrome/common/web_apps.cc - Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/web_apps.cc

Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Sync with Parser changes Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/web_apps.cc

diff --git a/chrome/common/web_apps.cc b/chrome/common/web_apps.cc

index 15647543c07bf35dcf9da4f76a7da93914da3ee8..8a2cdcca7802eb49bf5f68c5e072aed95ed985b2 100644

--- a/chrome/common/web_apps.cc

+++ b/chrome/common/web_apps.cc

@@ -218,7 +218,7 @@ bool ParseWebAppFromDefinitionFile(Value* definition_value,

base::JSONReader::ReadAndReturnError(

ResourceBundle::GetSharedInstance().GetRawDataResource(

IDR_WEB_APP_SCHEMA,

- ui::SCALE_FACTOR_NONE).as_string(),

+ ui::SCALE_FACTOR_NONE),

base::JSON_PARSE_RFC, // options

&error_code,

&error_message));

« no previous file with comments | « chrome/common/extensions/api/extension_api.cc ('k') | net/base/crl_set.cc » ('j') | no next file with comments »