base/json/json_parser.h - Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_parser.h

Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Sync with Parser changes Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_parser.h

diff --git a/base/json/json_parser.h b/base/json/json_parser.h

index 901e67911d32a7ab9b6df7e1631910a3e5ce562a..56e49a26a74d704548fbc53c0b1c444d01c782e1 100644

--- a/base/json/json_parser.h

+++ b/base/json/json_parser.h

@@ -66,7 +66,7 @@ class BASE_EXPORT_PRIVATE JSONParser {

// Parses the input string according to the set options and returns the

// result as a Value owned by the caller.

- Value* Parse(const std::string& input);

+ Value* Parse(const StringPiece& input);

// Returns the error code.

JSONReader::JsonParseError error_code() const;

« no previous file with comments | « no previous file | base/json/json_parser.cc » ('j') | no next file with comments »