chrome/common/extensions/api/extension_api.cc - Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/extension_api.cc

diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc

index 8feaad35a7cfaf721bdf18a0243fb32e395f2a82..e0d95f464a10c4e77cfad2a9d6fb15c3debb207c 100644

--- a/chrome/common/extensions/api/extension_api.cc

+++ b/chrome/common/extensions/api/extension_api.cc

@@ -67,7 +67,7 @@ scoped_ptr<ListValue> LoadSchemaList(const base::StringPiece& schema) {

std::string error_message;

scoped_ptr<Value> result(

base::JSONReader::ReadAndReturnError(

- schema.as_string(),

+ schema,

false, // allow trailing commas

NULL, // error code

&error_message));

« chrome/browser/extensions/component_loader.h ('K') | « chrome/browser/plugin_finder.cc ('k') | chrome/common/web_apps.cc » ('j') | no next file with comments »