chrome/browser/extensions/component_loader.h - Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_loader.h

Issue 10003001: Update JSONReader to take base::StringPiece instead of std::string (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/component_loader.h

diff --git a/chrome/browser/extensions/component_loader.h b/chrome/browser/extensions/component_loader.h

index 4329d05f10fff1c154d60d4ff941b50398a3841f..bb2e719fb60cf0c7157862b145e55c99e9f1ccfd 100644

--- a/chrome/browser/extensions/component_loader.h

+++ b/chrome/browser/extensions/component_loader.h

@@ -76,7 +76,8 @@ class ComponentLoader : public content::NotificationObserver {

// Parse the given JSON manifest. Returns NULL if it cannot be parsed, or if

// if the result is not a DictionaryValue.

- DictionaryValue* ParseManifest(const std::string& manifest_contents) const;

+ DictionaryValue* ParseManifest(const std::string& manifest_contents)

+ const;

Aaron Boodman 2012/04/15 21:04:29 no need to change this

// Clear the list of registered extensions.

void ClearAllRegistered();

« no previous file with comments | « base/json/json_reader.cc ('k') | chrome/browser/plugin_finder.cc » ('j') | no next file with comments »