Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10001008: Many type fixes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index 995a244337dc3cad8ea58310f6310e68baae0a87..5288e05bd3a6a70de769abf9a592425d3a7c0020 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -1885,7 +1885,8 @@ class SsaBuilder implements Visitor {
// argument, which is the type, and the second argument,
// which is the foreign code.
if (link.isEmpty() || link.isEmpty()) {
- compiler.cancel('At least two arguments expected', node: node.arguments);
+ compiler.cancel('At least two arguments expected',
+ node: node.argumentsNode);
}
link = link.tail.tail;
List<HInstruction> inputs = <HInstruction>[];
@@ -2683,24 +2684,24 @@ class SsaBuilder implements Visitor {
// Recursively build the test conditions. Leaves the result on the
// expression stack.
- void buildTests(Link<Node> expressions) {
+ void buildTests(Link<Node> remainingExpressions) {
// Build comparison for one case expression.
void left() {
Element equalsHelper = interceptors.getEqualsInterceptor();
HInstruction target = new HStatic(equalsHelper);
add(target);
- visit(expressions.head);
+ visit(remainingExpressions.head);
push(new HEquals(target, pop(), expression));
}
// If this is the last expression, just return it.
- if (expressions.tail.isEmpty()) {
+ if (remainingExpressions.tail.isEmpty()) {
left();
return;
}
void right() {
- buildTests(expressions.tail);
+ buildTests(remainingExpressions.tail);
}
handleLogicalAndOr(left, right, isAnd: false);
}

Powered by Google App Engine
This is Rietveld 408576698