Many type fixes.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
 
   String generateMethod(WorkItem work, HGraph graph) {
@@ skipping 218 matching lines @@
         return false;
       }
     } while (limits.contains(basicBlock));
     return true;
   }
 
   bool isCondition(SubGraph limits) {
     return isExpression(limits) && (limits.end.last is HConditionalBranch);
   }
 
-  void visitExpressionGraph(SubGraph subGraph) {
+  void visitExpressionGraph(SubGraph expressionSubGraph) {
     int oldState = generationState;
     generationState = STATE_FIRST_EXPRESSION;
-    visitSubGraph(subGraph);
+    visitSubGraph(expressionSubGraph);
     generationState = oldState;
   }
 
-  void visitConditionGraph(SubGraph subGraph) {
-    visitExpressionGraph(subGraph);
+  void visitConditionGraph(SubGraph conditionSubGraph) {
+    visitExpressionGraph(conditionSubGraph);
   }
 
   String temporary(HInstruction instruction) {
     int id = instruction.id;
     String name = names[id];
     if (name !== null) return name;
 
     if (instruction is HPhi) {
       HPhi phi = instruction;
       Element element = phi.element;
@@ skipping 83 matching lines @@
     }
   }
 
   void define(HInstruction instruction) {
     String name = temporary(instruction);
     declareVariable(name);
     buffer.add(" = ");
     visit(instruction, JSPrecedence.ASSIGNMENT_PRECEDENCE);
   }
 
-  void use(HInstruction argument, int expectedPrecedence) {
+  void use(HInstruction argument, int expectedPrecedenceForArgument) {
     if (isGenerateAtUseSite(argument)) {
-      visit(argument, expectedPrecedence);
+      visit(argument, expectedPrecedenceForArgument);
     } else if (argument is HIntegerCheck) {
       HIntegerCheck instruction = argument;
-      use(instruction.value, expectedPrecedence);
+      use(instruction.value, expectedPrecedenceForArgument);
     } else if (argument is HBoundsCheck) {
       HBoundsCheck instruction = argument;
-      use(instruction.index, expectedPrecedence);
+      use(instruction.index, expectedPrecedenceForArgument);
     } else if (argument is HTypeGuard) {
       HTypeGuard instruction = argument;
-      use(instruction.guarded, expectedPrecedence);
+      use(instruction.guarded, expectedPrecedenceForArgument);
     } else {
       buffer.add(temporary(argument));
     }
   }
 
-  visit(HInstruction node, int expectedPrecedence) {
+  visit(HInstruction node, int expectedPrecedenceForNode) {
     int oldPrecedence = this.expectedPrecedence;
-    this.expectedPrecedence = expectedPrecedence;
+    this.expectedPrecedence = expectedPrecedenceForNode;
     node.accept(this);
     this.expectedPrecedence = oldPrecedence;
   }
 
   void continueAsBreak(LabelElement target) {
     addIndentation();
     buffer.add("break ");
     writeContinueLabel(target);
     buffer.add(";\n");
   }
@@ skipping 91 matching lines @@
     TargetElement target = info.target;
     if (target !== null && target.isContinueTarget) {
       addIndentation();
       for (LabelElement label in info.labels) {
         if (label.isContinueTarget) {
           writeContinueLabel(label);
           buffer.add(":");
           continueAction[label] = continueAsBreak;
         }
       }
-      addImplicitContinueLabel();
+      writeImplicitContinueLabel(target);
       buffer.add(":{\n");
       continueAction[info.target] = implicitContinueAsBreak;
       indent++;
       visitSubGraph(info.body);
       indent--;
       addIndentation();
       buffer.add("}\n");
       continueAction.remove(info.target);
       for (LabelElement label in info.labels) {
         if (label.isContinueTarget) {
@@ skipping 1296 matching lines @@
 
 
   void beginLoop(HBasicBlock block) {
     // TODO(ngeoffray): Don't put labels on loops that don't bailout.
     String newLabel = pushLabel();
     if (block.hasGuards()) {
       startBailoutCase(block.guards, const <HTypeGuard>[]);
     }
 
     addIndentation();
-    for (SourceString label in block.loopInformation.labels) {
+    for (LabelElement label in block.loopInformation.labels) {
       writeLabel(label);
       buffer.add(":");
     }
     buffer.add('$newLabel: while (true) {\n');
     indent++;
 
     if (block.hasGuards()) {
       startBailoutSwitch();
     }
   }
@@ skipping 72 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }