Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8659)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10001004: Not blinking action tasks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index c2f205666c5a7367d03c75534007038032f13778..1d57a87423b971da1a508afb5b0be9ec05e52cc5 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -2242,11 +2242,6 @@ FileManager.prototype = {
}
this.previewSummary_.textContent = str('COMPUTING_SELECTION');
- // Removing childrens of task buttons and preview thumbnails after simple
- // event dispatched (see above). This can ensure a smooth disappearing
- // animation when nothing is selected.
- this.taskItems_.visible = false;
- this.taskItems_.clear();
removeChildren(this.previewThumbnails_);
var fileCount = 0;
@@ -2327,7 +2322,6 @@ FileManager.prototype = {
}
if (this.dialogType_ == FileManager.DialogType.FULL_PAGE) {
- this.taskItems_.clear();
// Some internal tasks cannot be defined in terms of file patterns,
// so we pass selection to check for them manually.
if (selection.directoryCount == 0 && selection.fileCount > 0) {
@@ -2543,7 +2537,7 @@ FileManager.prototype = {
if (defaultTask == null) defaultTask = task;
}
- this.taskItems_.visible = tasksCount > 0;
+ this.taskItems_.hidden = tasksCount == 0;
if (tasksCount > 1) {
// Duplicate default task in drop-down list.
this.renderTaskItem_(defaultTask);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698