Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2805)

Unified Diff: base/sync_socket.h

Issue 10000004: Make the CancellableSyncSocket non-blocking on Send, and blocking on Receive (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready for review now. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/sync_socket_posix.cc » ('j') | base/sync_socket_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sync_socket.h
diff --git a/base/sync_socket.h b/base/sync_socket.h
index 9bf8836d8bf85e39e755241be16060215a21d147..64a61372a0beba57713319a50ff2da35a9bd533f 100644
--- a/base/sync_socket.h
+++ b/base/sync_socket.h
@@ -7,7 +7,7 @@
#pragma once
// A socket abstraction used for sending and receiving plain
-// data. Because they are blocking, they can be used to perform
+// data. Because the receiving is blocking, they can be used to perform
// rudimentary cross-process synchronization with low latency.
#include "base/basictypes.h"
@@ -77,8 +77,8 @@ class BASE_EXPORT SyncSocket {
};
// Derives from SyncSocket and adds support for shutting down the socket from
-// another thread while a blocking Receive or Send is being done from the thread
-// that owns the socket.
+// another thread while a blocking Receive or a non-blocking Send is being done
tommi (sloooow) - chröme 2012/04/13 10:28:10 'non-blocking' in this context just makes it confu
no longer working on chromium 2012/04/13 11:50:50 Done.
+// from the thread that owns the socket.
class BASE_EXPORT CancelableSyncSocket : public SyncSocket {
public:
CancelableSyncSocket();
« no previous file with comments | « no previous file | base/sync_socket_posix.cc » ('j') | base/sync_socket_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698