Issue 9997003: Add back @domName annotations to dart:html

Issue 9997003: Add back @domName annotations to dart:html (Closed)

Created:
8 years, 8 months ago by Jacob

Modified:
8 years, 8 months ago

Reviewers:
nweiz, sra1, Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add back @domName annotations to dart:html BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6248

Patch Set 1 : Ready to review #

Total comments: 2

Patch Set 2 : updated dom and html after sync #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+210 lines, -402 lines)			Patch
M	lib/dom/dom.dart	View	1	7 chunks	+0 lines, -60 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1	14 chunks	+0 lines, -105 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		49 chunks	+100 lines, -130 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	1	45 chunks	+100 lines, -105 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

Make the code generator spit out domName annotations so that dartdoc can link up dart:dom ...

8 years, 8 months ago (2012-04-05 00:54:19 UTC) #1

nweiz

https://chromiumcodereview.appspot.com/9997003/diff/2001/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (left): https://chromiumcodereview.appspot.com/9997003/diff/2001/lib/html/dartium/html_dartium.dart#oldcode22203 lib/html/dartium/html_dartium.dart:22203: void $dom_addEventListener(String type, EventListener listener, [bool useCapture]); Do we ...

8 years, 8 months ago (2012-04-05 18:45:15 UTC) #2

Jacob

8 years, 8 months ago (2012-04-05 20:57:30 UTC) #4

Also synced and uploaded a new version that updates dart:dom and dart:html

https://chromiumcodereview.appspot.com/9997003/diff/2001/lib/html/dartium/htm...
File lib/html/dartium/html_dartium.dart (left):

https://chromiumcodereview.appspot.com/9997003/diff/2001/lib/html/dartium/htm...
lib/html/dartium/html_dartium.dart:22203: void $dom_addEventListener(String
type, EventListener listener, [bool useCapture]);
On 2012/04/05 18:45:16, nweiz wrote:
> Do we really want to add these for all the private methods? Doesn't seem
useful
> at all.

Discussed offline. These will make things easier for dartdoc.

Expand Messages | Collapse Messages