Issue 9980011: Analyze against lib/isolate/isolate_compiler.dart instead of isolate_runtime.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9980011: Analyze against lib/isolate/isolate_compiler.dart instead of isolate_runtime.dart. (Closed)

Created:
8 years, 8 months ago by devoncarew

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang), danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Analyze against lib/isolate/isolate_compiler.dart instead of isolate_runtime.dart. Committed: https://code.google.com/p/dart/source/detail?r=6230

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderAnyTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/config/import_any.config	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/config/import_dartium.config	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/config/import_vm.config	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

devoncarew

After talking with Siggi, we should be analyzing against isolate_compiler.dart instead of isolate_runtime.dart. (see http://codereview.chromium.org/9950143/)

8 years, 8 months ago (2012-04-04 18:26:10 UTC) #1

lgtm

Expand Messages | Collapse Messages