Issue 9977015: Add support for DOM node vs DOM object separation.

Issue 9977015: Add support for DOM node vs DOM object separation. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for DOM node vs DOM object separation. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6214

Patch Set 2 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
	M	lib/dom/scripts/systemnative.py	View	1	6 chunks	+22 lines, -6 lines	0 comments	Download
	M	lib/dom/templates/dom/native/cpp_header.template	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/9977015/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/9977015/diff/1/lib/dom/scripts/systemnative.py#newcode843 lib/dom/scripts/systemnative.py:843: if _IsNodeSubType(database, idl_type): will it return true for Node ...

8 years, 8 months ago (2012-04-04 18:41:56 UTC) #2

podivilov

Thanks! PTAL. https://chromiumcodereview.appspot.com/9977015/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/9977015/diff/1/lib/dom/scripts/systemnative.py#newcode843 lib/dom/scripts/systemnative.py:843: if _IsNodeSubType(database, idl_type): On 2012/04/04 18:41:56, antonmuhin ...

8 years, 8 months ago (2012-04-04 18:50:25 UTC) #3

LGTM

Expand Messages | Collapse Messages