Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9977011: get rid of dependency on htmlconverter for everything but swarm. (Closed)

Created:
8 years, 8 months ago by dgrove
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

get rid of dependency on htmlconverter for everything but swarm. move htmlconverter.py to swarm . Committed: https://code.google.com/p/dart/source/detail?r=6201

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1001 lines) Patch
D client/tools/htmlconverter.py View 1 chunk +0 lines, -558 lines 0 comments Download
D client/tools/htmlconverter_test.py View 1 chunk +0 lines, -415 lines 0 comments Download
M samples/dartcombat/README View 1 chunk +8 lines, -5 lines 1 comment Download
M samples/hi/README View 1 chunk +8 lines, -4 lines 0 comments Download
M samples/isolate_html/README View 1 chunk +8 lines, -5 lines 0 comments Download
M samples/slider/README View 1 chunk +8 lines, -6 lines 0 comments Download
M samples/sunflower/README View 1 chunk +8 lines, -5 lines 0 comments Download
A + samples/swarm/htmlconverter.py View 1 chunk +1 line, -1 line 0 comments Download
A + samples/swarm/htmlconverter_test.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years, 8 months ago (2012-04-04 17:56:12 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/9977011/diff/1/samples/dartcombat/README File samples/dartcombat/README (right): https://chromiumcodereview.appspot.com/9977011/diff/1/samples/dartcombat/README#newcode20 samples/dartcombat/README:20: $(DART_SDK)/bin/frogc --out=dartcombat.dart.js dartcombat.dart does dart.js search 'foo.dart' and ...
8 years, 8 months ago (2012-04-04 18:02:21 UTC) #2
dgrove
On 2012/04/04 18:02:21, sigmund wrote: > lgtm > > https://chromiumcodereview.appspot.com/9977011/diff/1/samples/dartcombat/README > File samples/dartcombat/README (right): > ...
8 years, 8 months ago (2012-04-04 19:40:16 UTC) #3
dgrove
8 years, 8 months ago (2012-04-04 19:40:20 UTC) #4 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698