Issue 9977007: Remember visibility range for DartVariable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9977007: Remember visibility range for DartVariable (Closed)

Created:
8 years, 8 months ago by scheglov

Modified:
8 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remember visibility range for DartVariable This will allow us to check name conflicts between local variables during refactoring. R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6192

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -8 lines)			Patch
M	compiler/java/com/google/dart/compiler/common/SourceInfo.java	View	2 chunks	+9 lines, -1 line	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/CompilationUnitImpl.java	View	6 chunks	+11 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartVariableImpl.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartVariableInfo.java	View	4 chunks	+27 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartVariableDeclaration.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartVariableImplTest.java	View	1 chunk	+89 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/TestAll.java	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 8 months ago (2012-04-04 17:18:24 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9977007/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/common/SourceInfo.java (right):

https://chromiumcodereview.appspot.com/9977007/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/common/SourceInfo.java:1: // Copyright
(c) 2011, the Dart project authors. Please see the AUTHORS file
nit: copyright year on multiple files

Expand Messages | Collapse Messages