Issue 9976004: Allow all different string-literals in map literals.

Issue 9976004: Allow all different string-literals in map literals. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow all different string-literals in map literals. Before spec. v0.8 only const strings were allowed. Committed: https://code.google.com/p/dart/source/detail?r=6521

Patch Set 2 : Enable string-literals in map constants. #

Total comments: 2

Patch Set 3 : Add description. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/CompileTimeConstantOTest.dart	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

const maps don't support string-interpolation yet. I'm working on that.

8 years, 8 months ago (2012-04-04 12:16:22 UTC) #1

floitsch

const maps work now too. (was *much* easier than expected :)

8 years, 8 months ago (2012-04-04 12:32:25 UTC) #2

ahe

LGTM! https://chromiumcodereview.appspot.com/9976004/diff/3001/tests/language/src/CompileTimeConstantOTest.dart File tests/language/src/CompileTimeConstantOTest.dart (right): https://chromiumcodereview.appspot.com/9976004/diff/3001/tests/language/src/CompileTimeConstantOTest.dart#newcode4 tests/language/src/CompileTimeConstantOTest.dart:4: Add description?

8 years, 8 months ago (2012-04-13 13:08:03 UTC) #4

floitsch

8 years, 8 months ago (2012-04-13 13:39:23 UTC) #5

https://chromiumcodereview.appspot.com/9976004/diff/3001/tests/language/src/C...
File tests/language/src/CompileTimeConstantOTest.dart (right):

https://chromiumcodereview.appspot.com/9976004/diff/3001/tests/language/src/C...
tests/language/src/CompileTimeConstantOTest.dart:4: 
On 2012/04/13 13:08:03, ahe wrote:
> Add description?

Done.

Expand Messages | Collapse Messages