Issue 9969209: Make dart2js executable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969209: Make dart2js executable. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make dart2js executable. Committed: https://code.google.com/p/dart/source/detail?r=6643

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -26 lines)			Patch
	M	dart/utils/compiler/build_helper.dart	View		1 chunk	+19 lines, -3 lines	2 comments	Download
	M	dart/utils/compiler/compiler.gyp	View		1 chunk	+19 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9969209/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/9969209/diff/1/dart/utils/compiler/build_helper.dart#newcode51 dart/utils/compiler/build_helper.dart:51: // Copyright (c) 2012, the Dart project authors. ...

8 years, 8 months ago (2012-04-17 15:19:39 UTC) #2

ahe

8 years, 8 months ago (2012-04-17 16:08:15 UTC) #3

Thank you, Kasper.

https://chromiumcodereview.appspot.com/9969209/diff/1/dart/utils/compiler/bui...
File dart/utils/compiler/build_helper.dart (right):

https://chromiumcodereview.appspot.com/9969209/diff/1/dart/utils/compiler/bui...
dart/utils/compiler/build_helper.dart:51: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/04/17 15:19:39, kasperl wrote:
> Would it make sense to throw this string into a top-level named constant so
that
> the indentation seems less off?

I'm using string interpolation. The best I can do is put it in a toplevel
method.

Expand Messages | Collapse Messages