Issue 9969192: Implement condition type checks in new compiler, thereby removing last bailouts.

Issue 9969192: Implement condition type checks in new compiler, thereby removing last bailouts. (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement condition type checks in new compiler, thereby removing last bailouts. Remove svn:eol-style property on various files. Committed: https://code.google.com/p/dart/source/detail?r=6613

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -32 lines)			Patch
M	runtime/vm/dart_api_message.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	runtime/vm/flow_graph_builder.h	View	1	3 chunks	+16 lines, -2 lines	0 comments	Download
MM	runtime/vm/flow_graph_builder.cc	View	1	15 chunks	+75 lines, -39 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comment. https://chromiumcodereview.appspot.com/9969192/diff/1/runtime/vm/flow_graph_builder.h File runtime/vm/flow_graph_builder.h (right): https://chromiumcodereview.appspot.com/9969192/diff/1/runtime/vm/flow_graph_builder.h#newcode278 runtime/vm/flow_graph_builder.h:278: class TestGraphVisitor : public ValueGraphVisitor { ...

8 years, 8 months ago (2012-04-16 23:52:38 UTC) #2

regis

8 years, 8 months ago (2012-04-17 00:17:18 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/9969192/diff/1/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder.h (right):

https://chromiumcodereview.appspot.com/9969192/diff/1/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder.h:278: class TestGraphVisitor : public
ValueGraphVisitor {
On 2012/04/16 23:52:38, srdjan wrote:
> Please add a comment why we need the node id and token index. I think the code
> would be simpler if you would always pass node_id and token index to the
> constructor.

Added comment and removed the setters. Both condition_node_id and
condition_token_index are now passed to the constructor.

Expand Messages | Collapse Messages