- Remove more String operator + from tests.

- Remove more String operator + from tests.
Committed: https://code.google.com/p/dart/source/detail?r=6527

[hausner, 2012-04-11 18:01:24]

I think StringConcatTest can be removed now. Otherwise, lgtm.

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Stri...
File tests/language/src/StringConcatTest.dart (right):

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Stri...
tests/language/src/StringConcatTest.dart:13: static final Tag = "version-" +
V.Version;
There are many more cases of string + in this test. Maybe the whole test should
be removed, it hardly makes any sense now.

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
File tests/language/src/SuperOperatorTest.dart (right):

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
tests/language/src/SuperOperatorTest.dart:14: val = "${val}${s}";
or val.concat(s);

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
tests/language/src/SuperOperatorTest.dart:30: super + ("${s}${s}");  // Call
A.operator+(this, s + s).
+ in comment is meaningless.

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
tests/language/src/SuperOperatorTest.dart:37: return "$temp$temp";
or return temp.concat(temp);

[hausner, 2012-04-11 18:10:25]

I just see that Kasper asked you to replace s.concat(x) with "$s$x" in another
review. Sorry, I guess it's just a matter of taste. Either one is fine of
course. But concat() is clearly better :-)

[Ivan Posva, 2012-04-13 13:29:17]

Thanks, I'll keep using string interpolation for now.

-Ivan

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Stri...
File tests/language/src/StringConcatTest.dart (right):

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Stri...
tests/language/src/StringConcatTest.dart:13: static final Tag = "version-" +
V.Version;
On 2012/04/11 18:01:24, hausner wrote:
> There are many more cases of string + in this test. Maybe the whole test
should
> be removed, it hardly makes any sense now.

I only addressed dynamically executed + operations on Strings. This one is a
constant and handled in the compiler. Since I did not have your pending change
this was not flagged.

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
File tests/language/src/SuperOperatorTest.dart (right):

https://chromiumcodereview.appspot.com/9969159/diff/1/tests/language/src/Supe...
tests/language/src/SuperOperatorTest.dart:30: super + ("${s}${s}");  // Call
A.operator+(this, s + s).
On 2012/04/11 18:01:24, hausner wrote:
> + in comment is meaningless.

Done.