Issue 9969153: Build fix: add DOMStringMap.h conversion include where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969153: Build fix: add DOMStringMap.h conversion include where needed. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Build fix: add DOMStringMap.h conversion include where needed. TBR=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6410

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
	M	lib/dom/scripts/generator.py	View		5 chunks	+8 lines, -12 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/9969153/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (left): https://chromiumcodereview.appspot.com/9969153/diff/1/lib/dom/scripts/generator.py#oldcode485 lib/dom/scripts/generator.py:485: match = re.match(r'Map<(\w*), (\w*)>$', type_name) why this is removed? ...

8 years, 8 months ago (2012-04-11 12:41:27 UTC) #2

podivilov

8 years, 8 months ago (2012-04-11 13:17:24 UTC) #3

https://chromiumcodereview.appspot.com/9969153/diff/1/lib/dom/scripts/generat...
File lib/dom/scripts/generator.py (left):

https://chromiumcodereview.appspot.com/9969153/diff/1/lib/dom/scripts/generat...
lib/dom/scripts/generator.py:485: match = re.match(r'Map<(\w*), (\w*)>$',
type_name)
On 2012/04/11 12:41:28, antonmuhin wrote:
> why this is removed?  and if you remove it, there is no need to return a list
> any more.

There is no such idl type as Map<String, String>. After fixing
fremontcutbuilder, NeededDartTypes for Map<String, String> would not be needed
at all.

Expand Messages | Collapse Messages