Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9969076: Add Dromaeo generated code size measurements (Closed)

Created:
8 years, 8 months ago by vsm
Modified:
8 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Dromaeo generated code size measurements Committed: https://code.google.com/p/dart/source/detail?r=6123

Patch Set 1 #

Patch Set 2 : Clean up duplicate code #

Patch Set 3 : "Delete the other one instead" #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -8 lines) Patch
M tools/testing/perf_testing/run_perf_tests.py View 1 2 5 chunks +131 lines, -8 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years, 8 months ago (2012-04-02 22:49:58 UTC) #1
Emily Fortuna
lgtm... but I think we're really at the point that we should start pulling these ...
8 years, 8 months ago (2012-04-03 01:00:35 UTC) #2
vsm
8 years, 8 months ago (2012-04-03 18:18:22 UTC) #3 
https://chromiumcodereview.appspot.com/9969076/diff/3002/tools/testing/perf_t...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/9969076/diff/3002/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:637: class
DromaeoSizeTest(TestRunner):
That was my original intent, but it's a non-trivial merge as these are running
different variants than either the existing dromaeo or code size.

On 2012/04/03 01:00:35, Emily Fortuna wrote:
> This works... it seems like it might be less verbose code-wise to also run the
> sizing tests as part of the other dromaeo tests, or, better, part of the other
> code size tests. But if you want to wait until we do a refactor of all of
this,
> that's an option.

https://chromiumcodereview.appspot.com/9969076/diff/3002/tools/testing/perf_t...
tools/testing/perf_testing/run_perf_tests.py:639: file output size of
Dromaeo."""
On 2012/04/03 01:00:35, Emily Fortuna wrote:
> This comment can probably be all on line line.

Done.

Powered by Google App Engine
This is Rietveld 408576698