Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 9969053: Lift restrictions for browser test to pass. (Closed)

Created:
8 years, 8 months ago by Anton Muhin
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Lift restrictions for browser test to pass. If test prints something, those prints may go between 'Content-Type:...' and 'PASS' strings. BUG=2371 Committed: https://code.google.com/p/dart/source/detail?r=6174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 8 months ago (2012-04-02 14:44:35 UTC) #1
Anton Muhin
We may want to restrict it somewhat, e.g. require that searched for lines are only ...
8 years, 8 months ago (2012-04-02 14:45:20 UTC) #2
Anton Muhin
Adding Bill too
8 years, 8 months ago (2012-04-04 16:22:20 UTC) #3
Bill Hesse
LGTM. I still think DumpRenderTree should be fixed to output its dump of the page ...
8 years, 8 months ago (2012-04-04 16:25:13 UTC) #4
Anton Muhin
8 years, 8 months ago (2012-04-04 16:26:42 UTC) #5
On 2012/04/04 16:25:13, Bill Hesse wrote:
> LGTM.  I still think DumpRenderTree should be fixed to output its dump of the
> page monolithically, with no scripts active, though.

Thanks, Bill.

Overall I agree, but it's ways bigger topic.  And to some extent very hard to
ensure.

Powered by Google App Engine
This is Rietveld 408576698