Issue 9969043: Adds Junit tests in dartc back into test.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969043: Adds Junit tests in dartc back into test.py (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
Emily Fortuna, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adds Junit tests in dartc back into test.py http://code.google.com/p/dart/issues/detail?id=2366 Committed: https://code.google.com/p/dart/source/detail?r=6080

Patch Set 2 : Some Junit tests have broken in interleaving patches #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -7 lines)			Patch
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	1	2 chunks	+20 lines, -0 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/ast/DartToSourceVisitorTest.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	1	4 chunks	+9 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/corelib/SharedTests.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

Looks like I broke a Junit test, we'll need to fix it before we turn ...

8 years, 8 months ago (2012-04-01 18:33:09 UTC) #1

scheglov

LGTM https://chromiumcodereview.appspot.com/9969043/diff/1001/compiler/javatests/com/google/dart/compiler/CompilerTestCase.java File compiler/javatests/com/google/dart/compiler/CompilerTestCase.java (right): https://chromiumcodereview.appspot.com/9969043/diff/1001/compiler/javatests/com/google/dart/compiler/CompilerTestCase.java#newcode260 compiler/javatests/com/google/dart/compiler/CompilerTestCase.java:260: return new URI("dart:core/" + srcName); May be URI.create(String) ...

8 years, 8 months ago (2012-04-01 18:52:52 UTC) #2

lgtm!

Expand Messages | Collapse Messages

Issue 9969043: Adds Junit tests in dartc back into test.py (Closed)

Description

Patch Set 1 #

Patch Set 2 : Some Junit tests have broken in interleaving patches #

Messages