Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 9969023: Fix two compile time const issues (Closed)

Created:
8 years, 8 months ago by hausner
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix two compile time const issues - For equality expressions, the operands do not have to be of same type. (Issue 1671) - Truncating division is allowed for any numerical type, not just integer. (Issue 1780) Spec has been updated accordingly and co19 issue 106 filed to fix faulty test. Committed: https://code.google.com/p/dart/source/detail?r=6059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M runtime/vm/ast.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 8 months ago (2012-03-30 18:30:32 UTC) #1
srdjan
8 years, 8 months ago (2012-03-30 18:41:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698