Issue 9969006: Code cleanup for speculative type optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969006: Code cleanup for speculative type optimization. (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, karlklose, ahe, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Code cleanup for speculative type optimization. Committed: https://code.google.com/p/dart/source/detail?r=6032

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
	M	lib/compiler/implementation/ssa/nodes.dart	View		2 chunks	+1 line, -18 lines	1 comment	Download
	M	lib/compiler/implementation/ssa/types.dart	View		1 chunk	+16 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM https://chromiumcodereview.appspot.com/9969006/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (left): https://chromiumcodereview.appspot.com/9969006/diff/1/lib/compiler/implementation/ssa/nodes.dart#oldcode859 lib/compiler/implementation/ssa/nodes.dart:859: // Does this node pNotentially affect control flow. ...

8 years, 8 months ago (2012-03-30 12:41:08 UTC) #3

floitsch

8 years, 8 months ago (2012-03-30 23:16:00 UTC) #4

LGTM.

https://chromiumcodereview.appspot.com/9969006/diff/1/lib/compiler/implementa...
File lib/compiler/implementation/ssa/types.dart (right):

https://chromiumcodereview.appspot.com/9969006/diff/1/lib/compiler/implementa...
lib/compiler/implementation/ssa/types.dart:102: HType desiredType =
computeDesiredType(instruction);
No need to compute the desired type if the 'newType' is non-ambiguous. That is,
if newType says that we are an 'int', we shouldn't even look at the desired
type.

Expand Messages | Collapse Messages