Issue 9969001: Typed array constructors with optional buffer offset and length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969001: Typed array constructors with optional buffer offset and length. (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Typed array constructors with optional buffer offset and length. A fix for Issue 2331 BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6069

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add file #

Patch Set 4 : merge #

Total comments: 1

Patch Set 5 : type #

Patch Set 6 : include htmldartium #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+524 lines, -183 lines)			Patch
M	client/tests/client/client.status	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
A	client/tests/client/dom/TypedArrays2Test.dart	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
A	client/tests/client/html/TypedArrays1Test.dart	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	client/tests/client/html/TypedArrays2Test.dart	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
M	lib/dom/dom.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1	11 chunks	+90 lines, -28 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/dom/scripts/systeminterface.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/dom/src/frog_FactoryProviders.dart	View		1 chunk	+0 lines, -51 lines	0 comments	Download
A	lib/dom/src/frog_TypedArrayFactoryProvider.dart	View	1 2	1 chunk	+113 lines, -0 lines	0 comments	Download
M	lib/dom/templates/dom/frog/frog_dom.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/html_frog.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	1 2 3 4 5	11 chunks	+95 lines, -32 lines	0 comments	Download
M	lib/html/src/frog_FactoryProviders.dart	View		2 chunks	+1 line, -52 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 8 months ago (2012-03-30 23:21:41 UTC) #2

LGTM besides typo in status file

https://chromiumcodereview.appspot.com/9969001/diff/5001/client/tests/client/...
File client/tests/client/client.status (right):

https://chromiumcodereview.appspot.com/9969001/diff/5001/client/tests/client/...
client/tests/client/client.status:38: dom/HistoryTest: Failg
Failg?

Expand Messages | Collapse Messages