Add a new attachTo method to HttpServer, for using an existing ServerSocket.

Add a new attachTo method to HttpServer, for using an existing ServerSocket.
Committed: https://code.google.com/p/dart/source/detail?r=6082

[Søren Gjesse, 2012-04-02 07:32:41]

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http.dart#n...
runtime/bin/http.dart:76: void attachTo(ServerSocket serverSocket);
How about calling this listenOn?

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:469: 
Looks as if this change is mixed with the previous change of handling closed
sockets. It should not be part of this change.

[Anders Johnsen, 2012-04-02 07:33:21]

Removed some lines I didn't intend for this commit.

[Anders Johnsen, 2012-04-02 07:36:52]

Updated.

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http.dart#n...
runtime/bin/http.dart:76: void attachTo(ServerSocket serverSocket);
On 2012/04/02 07:32:41, Søren Gjesse wrote:
> How about calling this listenOn?

Agreed, updated.

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:469: 
On 2012/04/02 07:32:41, Søren Gjesse wrote:
> Looks as if this change is mixed with the previous change of handling closed
> sockets. It should not be part of this change.

Removed :)

[Søren Gjesse, 2012-04-02 07:42:15]

Please add a test using this new method.

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http.dar...
runtime/bin/http.dart:76: void attachTo(ServerSocket serverSocket);
How about calling this listenOn - it somehow matches the listen above.

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
runtime/bin/http_impl.dart:632: _HttpServer() :
Fits on one line?

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
runtime/bin/http_impl.dart:666: int get port() => _server.port;
This will give an exception if _server is null. You should probably always set
_server and then have a flag to handle the closing.

[Anders Johnsen, 2012-04-02 08:12:34]

Added a test file.

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
runtime/bin/http_impl.dart:632: _HttpServer() :
On 2012/04/02 07:42:15, Søren Gjesse wrote:
> Fits on one line?

Done.

https://chromiumcodereview.appspot.com/9965053/diff/3001/runtime/bin/http_imp...
runtime/bin/http_impl.dart:666: int get port() => _server.port;
On 2012/04/02 07:42:15, Søren Gjesse wrote:
> This will give an exception if _server is null. You should probably always set
> _server and then have a flag to handle the closing.

Agreed, I've changed the logic a bit.

[Søren Gjesse, 2012-04-02 08:16:45]

lgtm

https://chromiumcodereview.appspot.com/9965053/diff/2008/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/2008/runtime/bin/http_imp...
runtime/bin/http_impl.dart:667: int get port() => _server === null ? -1 :
_server.port;
How about throwing an exception if the server has no socket?

[Anders Johnsen, 2012-04-02 08:24:34]

Committing.

https://chromiumcodereview.appspot.com/9965053/diff/2008/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9965053/diff/2008/runtime/bin/http_imp...
runtime/bin/http_impl.dart:667: int get port() => _server === null ? -1 :
_server.port;
On 2012/04/02 08:16:45, Søren Gjesse wrote:
> How about throwing an exception if the server has no socket?

Even better! :)