Issue 9965047: Make constant lists immutable.

Issue 9965047: Make constant lists immutable. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make constant lists immutable. Committed: https://code.google.com/p/dart/source/detail?r=6360

Patch Set 2 : Addressed comment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -20 lines)			Patch
M	lib/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	11 chunks	+26 lines, -15 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

Surprisingly easy change... (unless, of course, I missed something).

8 years, 8 months ago (2012-03-31 02:21:08 UTC) #1

karlklose

LGTM. https://chromiumcodereview.appspot.com/9965047/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/9965047/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode1219 lib/compiler/implementation/ssa/nodes.dart:1219: && inputs[1].isMutableArray()) { Move && to previous line ...

8 years, 8 months ago (2012-04-10 14:18:57 UTC) #3

floitsch

https://chromiumcodereview.appspot.com/9965047/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/9965047/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode1219 lib/compiler/implementation/ssa/nodes.dart:1219: && inputs[1].isMutableArray()) { On 2012/04/10 14:18:57, karlklose wrote: > ...

8 years, 8 months ago (2012-04-10 15:06:42 UTC) #4

LGTM!

Expand Messages | Collapse Messages